Organizations.listMembers() used _request()#591
Open
hiteda wants to merge 1 commit intogithub-tools:masterfrom
Open
Organizations.listMembers() used _request()#591hiteda wants to merge 1 commit intogithub-tools:masterfrom
hiteda wants to merge 1 commit intogithub-tools:masterfrom
Conversation
…es(), unlike other similar methods.
j-rewerts
requested changes
Oct 30, 2019
Member
j-rewerts
left a comment
j-rewerts
left a comment
There was a problem hiding this comment.
We're in the process of standardizing how we handle paging right now. This is good for people that want to request all available pages, but we'll need the ability to page through results as well.
Check out #596 for an example of what I'm thinking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organizations.listMembers() used _request() instead of _requestAllPages(), unlike other similar methods.